Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-mecab - Perl binding for MeCab https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233424 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|normal |medium pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pertusus@xxxxxxx ------- Additional Comments From pertusus@xxxxxxx 2007-05-08 12:56 EST ------- Issues: The following is not useful: export CXXFLAGS=$RPM_OPT_FLAGS If you use (like in the template) pure_install instead of install you won't need to remove $RPM_BUILD_ROOT%{perl_archlib}/perllocal.pod I think that the Requires: mecab = %{version} is not usefull, the soname dependency is enough. Otherwise the devel BuildRequires should also be versionned. ls -lR /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/MeCab.pm -r--r--r-- it is wrong, you can use what is in the template chmod -R u+w $RPM_BUILD_ROOT/* Remarks: I would personally not use -f for rm and mv to have build breaking when things change. I also don't like the use of %relnumber and %mainver in my opinion the clutter the spec unnecessarily. Regarding the license it is now included in the tarball, so it is fine with me, even though it certainly lacks something in the README. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review