[Bug 1176896] Review Request: nodejs-zip-stream - A streaming zip archive generator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1176896

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-zip-stream.noarch: W: only-non-binary-in-usr-lib
nodejs-zip-stream.noarch: W: dangling-symlink
/usr/lib/node_modules/zip-stream/node_modules/compress-commons
/usr/lib/node_modules/compress-commons
nodejs-zip-stream.noarch: W: dangling-symlink
/usr/lib/node_modules/zip-stream/node_modules/readable-stream
/usr/lib/node_modules/readable-stream
nodejs-zip-stream.noarch: W: dangling-symlink
/usr/lib/node_modules/zip-stream/node_modules/lodash
/usr/lib/node_modules/lodash
nodejs-zip-stream.src: W: strange-permission nodejs-zip-stream-dl-tests.sh
0755L
nodejs-zip-stream.src: W: invalid-url Source1:
nodejs-zip-stream-tests-0.5.0.tar.bz2


+ Source verified with upstream as (sha256sum)
srpm tarball:  c9cedcde5485b444722dd155c9d30941114acdc4c9a9836b67e66aad7d2c4823
upstream tarball: 
c9cedcde5485b444722dd155c9d30941114acdc4c9a9836b67e66aad7d2c4823 

+ License is "MIT" and included in its own LICENSE-MIT file.

+ follows nodejs packaging guidelines.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]