[Bug 1176895] Review Request: nodejs-compress-commons - A library that defines a common interface for working with archive formats

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1176895

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-compress-commons.noarch: W: only-non-binary-in-usr-lib
nodejs-compress-commons.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/nodejs-compress-commons/README.md
nodejs-compress-commons.noarch: W: dangling-symlink
/usr/lib/node_modules/compress-commons/node_modules/readable-stream
/usr/lib/node_modules/readable-stream
nodejs-compress-commons.noarch: W: dangling-symlink
/usr/lib/node_modules/compress-commons/node_modules/node-int64
/usr/lib/node_modules/node-int64
nodejs-compress-commons.noarch: W: dangling-symlink
/usr/lib/node_modules/compress-commons/node_modules/crc32-stream
/usr/lib/node_modules/crc32-stream
nodejs-compress-commons.noarch: W: dangling-symlink
/usr/lib/node_modules/compress-commons/node_modules/buffer-crc32
/usr/lib/node_modules/buffer-crc32
nodejs-compress-commons.src: W: strange-permission
nodejs-compress-commons-dl-tests.sh 0755L
nodejs-compress-commons.src: W: invalid-url Source1:
nodejs-node-compress-commons-tests-0.2.0.tar.bz2
2 packages and 0 specfiles checked; 0 errors, 8 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball:  ba0b779a52bc3fc850cb9e8c0de373c4afec87565cd51f476038c6ea6abdd517
upstream tarball:  
ba0b779a52bc3fc850cb9e8c0de373c4afec87565cd51f476038c6ea6abdd517

+ License is "MIT" and included in its own LICENSE-MIT file.

+ follows nodejs packaging guidelines.

Suggestions:
1) Fix rpmlint warning wrong-file-end-of-line-encoding

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]