[Bug 1176445] Review Request: nodejs-grunt-angular-templates - Grunt build task to concatenate & register your AngularJS templates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1176445

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-grunt-angular-templates.noarch: W: spelling-error %description -l en_US
minifying -> magnifying, indemnifying, signifying
nodejs-grunt-angular-templates.noarch: W: spelling-error %description -l en_US
templateCache -> template Cache, template-cache, contemplate
nodejs-grunt-angular-templates.noarch: W: only-non-binary-in-usr-lib
nodejs-grunt-angular-templates.noarch: W: dangling-symlink
/usr/lib/node_modules/grunt-angular-templates/node_modules/html-minifier
/usr/lib/node_modules/html-minifier
nodejs-grunt-angular-templates.src: W: spelling-error %description -l en_US
minifying -> magnifying, indemnifying, signifying
nodejs-grunt-angular-templates.src: W: spelling-error %description -l en_US
templateCache -> template Cache, template-cache, contemplate
2 packages and 0 specfiles checked; 0 errors, 6 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball: 5025932451c473b6089af0967605700952afddadfe7ab0168150577a07a201e2
upstream tarball: 
5025932451c473b6089af0967605700952afddadfe7ab0168150577a07a201e2

+ License is "MIT" and its text is given in LICENSE file.

+ follows nodejs packaging guidelines.

Looks good.
APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]