https://bugzilla.redhat.com/show_bug.cgi?id=1142508 --- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * The .spec file you are linking differs from the .spec from SRPM - But the difference is just subtle, so not a blocker. * Update to the latest upstream version. - There is already available true 1.0.1. Please consider update to the latest upstream version. * Test suite - Could you please execute the gem's test suite? - Since there seems to be circular dependency, I suggest you to follow the bootstrapping guidelines [1]. - When the test suite is shipped in separate source package, I prefer to unpack it in the %check section. It does not pollute the original installation then. * License file should be in main package - Please move the LICENSE.txt file into main package. * Move the VERSION file into -doc sub-package - It does not look like the VERSION file is used for runtime. Please move it into the -doc subpackage. [1] https://fedoraproject.org/wiki/Packaging:Guidelines#Bootstrapping -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review