https://bugzilla.redhat.com/show_bug.cgi?id=1168692 --- Comment #4 from Vladimir Stackov <amigo.elite@xxxxxxxxx> --- (In reply to Juan Orti from comment #3) > (In reply to Vladimir Stackov from comment #2) > > Greetings, > > > > a few comments: > > > > 1. Why not to push latest SPEC to your pull-request? > > I mean this: https://github.com/mystilleef/FedoraZram/pull/12/files > > It could be merged and then you can use upstream SOURCE. > > That is another repo. I took the scripts from > https://lists.fedoraproject.org/pipermail/devel/2014-November/204684.html So maby you should follow https://fedoraproject.org/wiki/Staying_close_to_upstream_projects? lists.fedoraproject.org isn't upstream. > > > > > 2. You could easily remove empty %build from your SPEC. > > rpmlint warns against that Ok, it's all up to you :) > > > > > 4. Why you don't want to include zramstat? It was very useful util. > > I see that script is from https://github.com/mystilleef/FedoraZram , I could > merge it, but we are talking about other repo again. What do you mean when you say "other repo"? It was upstream. > > > > > 5. Why you decided to use manual install instead of %makeinstall? > > There is no makefile Then it's your chance to use upstream repo :) https://github.com/mystilleef/FedoraZram/blob/master/Makefile -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review