https://bugzilla.redhat.com/show_bug.cgi?id=1168692 --- Comment #3 from Juan Orti <juan.orti@xxxxxxxxxxxx> --- (In reply to Vladimir Stackov from comment #2) > Greetings, > > a few comments: > > 1. Why not to push latest SPEC to your pull-request? > I mean this: https://github.com/mystilleef/FedoraZram/pull/12/files > It could be merged and then you can use upstream SOURCE. That is another repo. I took the scripts from https://lists.fedoraproject.org/pipermail/devel/2014-November/204684.html > > 2. You could easily remove empty %build from your SPEC. rpmlint warns against that > > 3. Package name is misleading. It's not related to zswap so you should > probably rename it to something like zramctl. The script creates a swap on zram, so I think zram-swap fits quite well. > > 4. Why you don't want to include zramstat? It was very useful util. I see that script is from https://github.com/mystilleef/FedoraZram , I could merge it, but we are talking about other repo again. > > 5. Why you decided to use manual install instead of %makeinstall? There is no makefile -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review