Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-SGML-Parser-OpenSP - Perl interface to the OpenSP SGML and XML parser https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237883 cweyl@xxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |cweyl@xxxxxxxxxxxxxxx Flag| |fedora-review+ ------- Additional Comments From cweyl@xxxxxxxxxxxxxxx 2007-05-06 13:23 EST ------- You should include perl(Test::More) as an explicit BR -- I'm not seeing it being pulled in by perl-Test-Pod (on my system at least). Taking care of the rpmlint warnings is trivial in %prep -- sed -i 's/\r//' samples/* -- so this should be taken care of as well. If Test::Pod::Coverage is available on the distros you're building for, its use is strongly encouraged as a matter of form, but I'm not insisting on it for reasons covered several times here and in other places :) APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review