Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-File-Passwd - Manipulate many kinds of password files Alias: pear-File-Passwd https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232165 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-05-06 13:21 EST ------- Builds fine and rpmlint is clean. Everything looks good, although I'm curious about the split of the -samba subpackage. The additional dependencies from php-pear-Crypt-CHAP only total about 200K, which isn't a really big deal but I guess it is nonzero. It looks like the code handles the missing Smb module well (raising an exception instead of just bombing) so I don't suppose it will hurt anything. But if you were trying to save folks from having to install samba, then there's not much point because even now the -samba module doesn't require samba (just a few encryption libs). You might also consider calling the subpackage "-Smb" since that's what the module itself is called. We don't really have any guidelines for this, so I suppose it's up to you. I don't see any blockers, though. Review: * source files match upstream: b01af05eb1c9714737ea5aba0b409c4dc6e6e62363a36a6c4b0a0d0048b69edb File_Passwd-1.1.6.tgz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: php-pear-File-Passwd-1.1.6-1.fc7.noarch.rpm php-pear(File_Passwd) = 1.1.6 php-pear-File-Passwd = 1.1.6-1.fc7 = /bin/sh /usr/bin/pear php-pear(PEAR) php-pear-File-Passwd-samba-1.1.6-1.fc7.noarch.rpm php-pear-File-Passwd-samba = 1.1.6-1.fc7 = php-pear(Crypt_CHAP) >= 1.0.0 php-pear-File-Passwd = 1.1.6-1.fc7 * %check is not present; no test suite upstream. * owns the directories it creates. * doesn't own any directories it shouldn't. /usr/share/pear/File is also owned by php-pear-File but it is not a dependency (and it doesn't need to be). * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED, I'll leave it to you to decide whether you really need the subpackage. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review