https://bugzilla.redhat.com/show_bug.cgi?id=1105613 --- Comment #16 from MartinKG <mgansser@xxxxxxxx> --- (In reply to Lubomir Rintel from comment #15) > Looking well enough, taking it for a review: > > * Named correctly > * Version correct > * License good for Fedora > * License text present > - License tag might be incorrect (see below) > * SPEC file clean and legible > * RPMLint happy > - Filelist contains an orphan (see below) > - Requires might be missing a dependency (see below) > * Provides fine > * Builds fine in mock > > 0.) The "Url" tag seems wrong: > > Project's web site seems to be http://otter-browser.org/ done > > 1.) "License" tag might be wrong: > > e.g. the header at ./src/core/SettingsManager.h suggest that it's GPLv3+? > done > 2.) You install into %{_datadir}/icons/hicolor, but don't own it or depends > on anything that would own it. > removed, done. > Also, please consider adding AppData. While it's not strictly required yet, > your application won't show up in the sotware center without it. See draft > guidelines: > > https://fedoraproject.org/wiki/User:Rhughes/DraftAppDataGuidelines done Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/otter-browser.spec Spec URL: https://martinkg.fedorapeople.org/Review/SRPMS/otter-browser-0.9.04-0.1.beta4git0bbf467.fc20.src.rpm %changelog * Mon Dec 08 2014 Martin Gansser <martinkg@xxxxxxxxxxxxxxxxx> - 0.9.04-0.1.beta4git0bbf467 - Update to 0.9.04-0.1.beta4 - correct project's web site url - correct license tag - removed %%{_datadir}/icons/hicolor was not owned or used - added %%check section - added BR libappstream-glib - added appdata.xml file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review