https://bugzilla.redhat.com/show_bug.cgi?id=1105613 Lubomir Rintel <lkundrak@xxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lkundrak@xxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |lkundrak@xxxxx Flags| |fedora-review? --- Comment #15 from Lubomir Rintel <lkundrak@xxxxx> --- Looking well enough, taking it for a review: * Named correctly * Version correct * License good for Fedora * License text present - License tag might be incorrect (see below) * SPEC file clean and legible * RPMLint happy - Filelist contains an orphan (see below) - Requires might be missing a dependency (see below) * Provides fine * Builds fine in mock 0.) The "Url" tag seems wrong: Project's web site seems to be http://otter-browser.org/ 1.) "License" tag might be wrong: e.g. the header at ./src/core/SettingsManager.h suggest that it's GPLv3+? 2.) You install into %{_datadir}/icons/hicolor, but don't own it or depends on anything that would own it. Also, please consider adding AppData. While it's not strictly required yet, your application won't show up in the sotware center without it. See draft guidelines: https://fedoraproject.org/wiki/User:Rhughes/DraftAppDataGuidelines -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review