https://bugzilla.redhat.com/show_bug.cgi?id=1060924 Ken Dreyer <ktdreyer@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #6 from Ken Dreyer <ktdreyer@xxxxxxxxxxxx> --- (In reply to Dan Callaghan from comment #5) > So I found it was easier to just selectively install the stuff we want > during %install, and then just put %{gem_instdir} and %{gem_extdir_mir} in > %files. That seemed easier than installing all the gem contents in %install > and then %exclude'ing all the extraneous stuff in %files. But I can change > it to do that if you think it's important. Ok, I don't see this as critical, and I think that was the only remaining issue. Looks good to me - APPROVED. Thanks very much for your patience on this bug Dan. I really wish I'd responded sooner. I had my first child in July and changed jobs last month so it's been a busy latter half of this year :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review