https://bugzilla.redhat.com/show_bug.cgi?id=1060924 --- Comment #5 from Dan Callaghan <dcallagh@xxxxxxxxxx> --- Sorry it's taken me so long to get back to this. (In reply to Ken Dreyer from comment #4) > Issues: > ======= > - Instead of packaging all of %{gem_instdir} in one go, please break the > %files > lists out and use "%{gem_libdir}", "%exclude %{gem_cache}", "%doc > %{gem_docdir}" like other gems in Fedora. %{gem_docdir} should go into a > -doc > subpackage. Hmm. So I don't want to include the gem docs, they have no content. The gem also installs all its sources and .o files under ext/unicode/ which I assume is undesirable. So I found it was easier to just selectively install the stuff we want during %install, and then just put %{gem_instdir} and %{gem_extdir_mir} in %files. That seemed easier than installing all the gem contents in %install and then %exclude'ing all the extraneous stuff in %files. But I can change it to do that if you think it's important. > - Please run the test suite during %check or add a note in the comments to > explain why the test suite does not work. test.rb isn't a test suite, it seems to be more for visual testing. But I can still run it during %check, to at least make sure the module can be loaded. > - Mind filing a bug upstream about shipping the license text? "If the source > package does not include license text(s) as a separate file from upstream, > the packager SHOULD query upstream to include it." Also, Ruby's license.txt > contains references to a file called "LEGAL" which isn't really relevant to > the unicode gem, or the "BSDL" file, which is not included in the RPM. It > would be great to just get that sorted out upstream in the gem. Filed: https://github.com/blackwinter/unicode/issues/7 > - Source1 can use HTTPS. Fixed. http://fedorapeople.org/~dcallagh/rubygem-unicode/rubygem-unicode.spec http://fedorapeople.org/~dcallagh/rubygem-unicode/rubygem-unicode-0.4.4.1-2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review