[Bug 1170875] Review Request: budgie-desktop - An elegant desktop with GNOME integration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1170875



--- Comment #4 from Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> ---
(In reply to Ralf Corsepius from comment #3)
> Some remarks:
> 
> - The "# Adjust for Fedora's multilib directory layout"
> section from %build is a hack playing with the symtops of an upstream bug
> (They miss to propagate some configuration parameters to "*.pc").
> 
> I'd propose this patch instead:
> <snip>

Right. Was thinking of patching the .pc.in file directly but wasn't sure if
that layout (with pkgconfig hard-coded to /usr/lib but the libraries themselves
elsewhere) might make sense in some other distribution.

But we should at least try and upstream it, so I'll submit a pull request with
the patch and, meanwhile, use it instead of dynamically using sed

> 
> - Building is non-verbose.
> You should append --disable-silent-rules to %configure.

Fixing it in -2, thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]