[Bug 1170875] Review Request: budgie-desktop - An elegant desktop with GNOME integration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1170875

Ralf Corsepius <rc040203@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203@xxxxxxxxxx



--- Comment #3 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
Some remarks:

- The "# Adjust for Fedora's multilib directory layout"
section from %build is a hack playing with the symtops of an upstream bug (They
miss to propagate some configuration parameters to "*.pc").

I'd propose this patch instead:
<snip>
--- budgie-plugin/budgie-1.0.pc.in
+++ budgie-plugin/budgie-1.0.pc.in
@@ -1,8 +1,8 @@
-prefix=/usr
-exec_prefix=${prefix}
-libdir=${exec_prefix}/lib
-includedir=${prefix}/include
-datarootdir=${prefix}/share
+prefix=@prefix@
+exec_prefix=@prefix@
+libdir=@libdir@
+includedir=@includedir@
+datarootdir=@datarootdir@

 Name: Budgie
 Description: Budgie Library
</snip>

- Building is non-verbose.
You should append --disable-silent-rules to %configure.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]