[Bug 1169895] Review Request: python-sievelib - Client-side SIEVE library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1169895



--- Comment #2 from Juan Orti <juan.orti@xxxxxxxxxxxx> ---
(In reply to Florian "der-flo" Lehner from comment #1)
> Hi Juan!
> 
> There are a few things:
> 
> [ ] From rplmlint:
>     python-sievelib.noarch: E: non-executable-script
> /usr/lib/python2.7/site-packages/sievelib/parser.py 0644L /usr/bin/env
>     python-sievelib.noarch: E: non-executable-script
> /usr/lib/python2.7/site-packages/sievelib/managesieve.py 0644L /usr/bin/env
>     For this please take a look at:
> https://fedoraproject.org/wiki/Packaging_tricks > Remove shebang from Python
> libraries
> 

Good point, I've include that code snippet to remove the shebangs.

> [ ] Please update %url to something package related.
>     pypi.python.org is too generic.
> 

Done.

> [ ] Don't miss the license text file 
>     https://github.com/tonioo/sievelib/blob/master/COPYING

Done.

Spec URL: https://jorti.fedorapeople.org/python-sievelib/python-sievelib.spec
SRPM URL:
https://jorti.fedorapeople.org/python-sievelib/python-sievelib-0.8-2.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]