https://bugzilla.redhat.com/show_bug.cgi?id=1169793 Florian "der-flo" Lehner <dev@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |dev@xxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |dev@xxxxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Florian "der-flo" Lehner <dev@xxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 72 files have unknown license. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [-]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. ---> https://github.com/snowballstem/snowball/issues/10 [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. ---> http://koji.fedoraproject.org/koji/taskinfo?taskID=8277937 [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libstemmer-0-1.585svn.fc22.x86_64.rpm libstemmer-devel-0-1.585svn.fc22.x86_64.rpm libstemmer-0-1.585svn.fc22.src.rpm libstemmer-devel.x86_64: W: only-non-binary-in-usr-lib libstemmer-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint libstemmer libstemmer-devel libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 danish_ISO_8859_1_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 danish_ISO_8859_1_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 danish_ISO_8859_1_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 danish_UTF_8_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 danish_UTF_8_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 danish_UTF_8_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 german_ISO_8859_1_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 german_ISO_8859_1_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 german_ISO_8859_1_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 german_UTF_8_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 german_UTF_8_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 german_UTF_8_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 dutch_ISO_8859_1_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 dutch_ISO_8859_1_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 dutch_ISO_8859_1_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 dutch_UTF_8_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 dutch_UTF_8_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 dutch_UTF_8_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 english_ISO_8859_1_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 english_ISO_8859_1_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 english_ISO_8859_1_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 english_UTF_8_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 english_UTF_8_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 english_UTF_8_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 spanish_ISO_8859_1_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 spanish_ISO_8859_1_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 spanish_ISO_8859_1_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 spanish_UTF_8_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 spanish_UTF_8_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 spanish_UTF_8_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 finnish_ISO_8859_1_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 finnish_ISO_8859_1_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 finnish_ISO_8859_1_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 finnish_UTF_8_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 finnish_UTF_8_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 finnish_UTF_8_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 french_ISO_8859_1_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 french_ISO_8859_1_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 french_ISO_8859_1_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 french_UTF_8_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 french_UTF_8_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 french_UTF_8_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 hungarian_ISO_8859_2_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 hungarian_ISO_8859_2_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 hungarian_ISO_8859_2_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 hungarian_UTF_8_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 hungarian_UTF_8_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 hungarian_UTF_8_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 italian_ISO_8859_1_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 italian_ISO_8859_1_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 italian_ISO_8859_1_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 italian_UTF_8_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 italian_UTF_8_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 italian_UTF_8_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 norwegian_ISO_8859_1_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 norwegian_ISO_8859_1_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 norwegian_ISO_8859_1_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 norwegian_UTF_8_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 norwegian_UTF_8_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 norwegian_UTF_8_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 portuguese_ISO_8859_1_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 portuguese_ISO_8859_1_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 portuguese_ISO_8859_1_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 portuguese_UTF_8_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 portuguese_UTF_8_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 portuguese_UTF_8_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 porter_ISO_8859_1_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 porter_ISO_8859_1_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 porter_ISO_8859_1_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 porter_UTF_8_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 porter_UTF_8_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 porter_UTF_8_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 romanian_ISO_8859_2_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 romanian_ISO_8859_2_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 romanian_ISO_8859_2_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 romanian_UTF_8_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 romanian_UTF_8_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 romanian_UTF_8_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 russian_KOI8_R_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 russian_KOI8_R_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 russian_KOI8_R_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 russian_UTF_8_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 russian_UTF_8_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 russian_UTF_8_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 swedish_ISO_8859_1_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 swedish_ISO_8859_1_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 swedish_ISO_8859_1_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 swedish_UTF_8_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 swedish_UTF_8_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 swedish_UTF_8_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 turkish_UTF_8_create_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 turkish_UTF_8_close_env libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 turkish_UTF_8_stem libstemmer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libstemmer.so.0.0.0 SN_set_current libstemmer-devel.x86_64: W: only-non-binary-in-usr-lib libstemmer-devel.x86_64: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 96 warnings. # echo 'rpmlint-done:' ---> https://www.redhat.com/archives/fedora-extras-list/2006-July/msg00569.html Requires -------- libstemmer (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) rtld(GNU_HASH) libstemmer-devel (rpmlib, GLIBC filtered): libstemmer(x86-64) libstemmer.so.0()(64bit) Provides -------- libstemmer: libstemmer libstemmer(x86-64) libstemmer.so.0()(64bit) libstemmer-devel: libstemmer-devel libstemmer-devel(x86-64) Source checksums ---------------- http://snowball.tartarus.org/dist/libstemmer_c.tgz : CHECKSUM(SHA256) this package : 6530c3638f29f5b03bc3786bb9212e39adaf3bf15b5b0a483b2eb5111f7f416e CHECKSUM(SHA256) upstream package : 6530c3638f29f5b03bc3786bb9212e39adaf3bf15b5b0a483b2eb5111f7f416e Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1169793 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ===== Solution ===== APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review