[Bug 1169066] Review Request: perl-Net-RabbitMQ - Interact with RabbitMQ over AMQP using librabbitmq

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1169066

Petr Šabata <psabata@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |psabata@xxxxxxxxxx



--- Comment #2 from Petr Šabata <psabata@xxxxxxxxxx> ---
Indeed, as David points out, this package is bundling librabbitmq 0.0.1.  It
needs to be unbundled and the code ported to our system librabbitmq.

Also, a couple of things I noticed from a quick glance at the SPEC:

#1 Upstream URL is pointing to a "different distribution" (this is because of
the two dashes in the name; upstream packaging seems a bit broken, by the way).

#2 You should use the %{version} macro in the source URL.

#3 "make test | grep 'Failed 1/6 subtests'" -- huh?  So the tests fail but you
want to make it look as if they don't or what is this sorcery?

#4 A build dependency on librabbitmq isn't what you want, even after you
unbundle the library.  You should depend on the devel subpackage.


This will require some work, both here and upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]