[Bug 1166919] Review Request: python-fastcache - C implementation of python3 lru_cache

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1166919



--- Comment #7 from Jerry James <loganjerry@xxxxxxxxx> ---
(In reply to Antonio Trande from comment #6)
> - I would list all BR of python3 package among python3-%{pkgname}
> definitions.

This is a stylistic issue, and I prefer the way I have it.  (I can look at the
spec file and see all of the BuildRequires in one place, no need to search.)

> - %{python2_sitearch}/%{pkgname} and %{python3_sitearch}/%{pkgname}
>   %{python2_sitearch}/*.egg-info and %{python3_sitearch}/*.egg-info 
>   not explicitely listed. 
>   
>   %{python2_sitearch}/%{pkgname}* is too recapitulatory in my opinion.

Okay, changed.

> - Tests seem mute and maybe they are not started at all. 
>   Use a verbose py.test command; something like this

Thanks for the tip.  I have taken your suggested approach.

New URLs:
Spec URL:
https://jjames.fedorapeople.org/python-fastcache/python-fastcache.spec
SRPM URL:
https://jjames.fedorapeople.org/python-fastcache/python-fastcache-1.0.2-2.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]