[Bug 1166919] Review Request: python-fastcache - C implementation of python3 lru_cache

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1166919



--- Comment #6 from Antonio Trande <anto.trande@xxxxxxxxx> ---
- LICENSE file is correctly tagged with %license macro
  (New change from F21).

- I would list all BR of python3 package among python3-%{pkgname} definitions.

- %{python2_sitearch}/%{pkgname} and %{python3_sitearch}/%{pkgname}
  %{python2_sitearch}/*.egg-info and %{python3_sitearch}/*.egg-info 
  not explicitely listed. 

  %{python2_sitearch}/%{pkgname}* is too recapitulatory in my opinion.

- Tests seem mute and maybe they are not started at all. 
  Use a verbose py.test command; something like this

%check
# Python 2 tests
pushd %{pkgname}-%{version}
py.cleanup-2.7 -p
export PYTHONPATH=build/lib.linux-%{_arch}-2.7/fastcache/tests
py.test-2.7 -v --ignore=fastcache/tests
popd

%if 0%{?with_py3}
# Python 3 tests
pushd python3-%{pkgname}-%{version}
py.cleanup-3.4 -p
export PYTHONPATH=build/lib.linux-%{_arch}-3.4/fastcache/tests
py.test-3.4 -v --ignore=fastcache/tests
popd
%endif

- /usr/share/licenses must not be owned by this package.
  False positive.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- If (and only if) the source package includes the text of the license(s) in
  its own file, then that file, containing the text of the license(s) for the
  package is included in %doc.
  Note: Cannot find LICENSE in rpm(s)
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 20 files have unknown license. Detailed output of
     licensecheck in /home/sagitter/1166919-python-fastcache/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/licenses
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
     Note: Test run failed
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Test run failed
[x]: Packages must not store files under /srv, /opt or /usr/local
     Note: Test run failed
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.

Python:
[x]: Binary eggs must be removed in %prep
     Note: Test run failed
[x]: Python eggs must not download any dependencies during the build process.
     Note: Test run failed
[x]: A package which is used by another package via an egg interface should
     provide egg info.
     Note: Test run failed
[!]: Package meets the Packaging Guidelines::Python
     Note: Test run failed
[x]: Package contains BR: python2-devel or python3-devel

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-fastcache
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[-]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
     Note: Test run failed
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python-fastcache-1.0.2-1.fc22.i686.rpm
          python3-fastcache-1.0.2-1.fc22.i686.rpm
          python-fastcache-1.0.2-1.fc22.src.rpm
python-fastcache.i686: W: spelling-error Summary(en_US) lru -> Lr
python-fastcache.i686: W: spelling-error %description -l en_US lru -> Lr
python-fastcache.i686: W: spelling-error %description -l en_US functools ->
functions
python3-fastcache.i686: W: spelling-error %description -l en_US lru -> Lr
python3-fastcache.i686: W: spelling-error %description -l en_US functools ->
functions
python-fastcache.src: W: spelling-error Summary(en_US) lru -> Lr
python-fastcache.src: W: spelling-error %description -l en_US lru -> Lr
python-fastcache.src: W: spelling-error %description -l en_US functools ->
functions
3 packages and 0 specfiles checked; 0 errors, 8 warnings.




Rpmlint (installed packages)
----------------------------
]0;<mock-chroot><mock-chroot>[root@localhost /]# rpmlint python-fastcache
python3-fastcache
python-fastcache.i686: W: spelling-error Summary(en_US) lru -> URL
python-fastcache.i686: W: spelling-error %description -l en_US lru -> URL
python-fastcache.i686: W: spelling-error %description -l en_US functools ->
functions
python3-fastcache.i686: W: spelling-error %description -l en_US lru -> URL
python3-fastcache.i686: W: spelling-error %description -l en_US functools ->
functions
2 packages and 0 specfiles checked; 0 errors, 5 warnings.
]0;<mock-chroot><mock-chroot>[root@localhost /]# echo 'rpmlint-done:'



Requires
--------
python-fastcache (rpmlib, GLIBC filtered):
    libc.so.6
    libpthread.so.0
    libpython2.7.so.1.0
    python(abi)
    rtld(GNU_HASH)

python3-fastcache (rpmlib, GLIBC filtered):
    libc.so.6
    libpthread.so.0
    libpython3.4m.so.1.0
    python(abi)
    rtld(GNU_HASH)



Provides
--------
python-fastcache:
    python-fastcache
    python-fastcache(x86-32)

python3-fastcache:
    python3-fastcache
    python3-fastcache(x86-32)



Unversioned so-files
--------------------
python-fastcache: /usr/lib/python2.7/site-packages/fastcache/_lrucache.so
python3-fastcache:
/usr/lib/python3.4/site-packages/fastcache/_lrucache.cpython-34m.so

Source checksums
----------------
https://github.com/pbrady/fastcache/archive/v1.0.2.tar.gz :
  CHECKSUM(SHA256) this package     :
e672f1bb75efeb5d829f8b6cb3f1f3e035dae92567eb5eb2fbc73bf260ebdf7e
  CHECKSUM(SHA256) upstream package :
e672f1bb75efeb5d829f8b6cb3f1f3e035dae92567eb5eb2fbc73bf260ebdf7e


Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -m fedora-rawhide-i386 -b 1166919
Buildroot used: fedora-rawhide-i386
Active plugins: Python, Generic, Shell-api, C/C++
Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP,
Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]