https://bugzilla.redhat.com/show_bug.cgi?id=1169284 --- Comment #2 from Emmanuel Seyman <emmanuel@xxxxxxxxx> --- (In reply to Petr Šabata from comment #1) > Oh c'mon, so many common things... Yeah, sorry about that. :-( > Missing BRs: perl, Exporter, strict, warnings. added. > The minimum required version of Test::Pod is 1.22. > The minimum required version of Test::Pod::Coverage is 1.08. > Consider limiting the BRs to these versions. Done. > 00-pod-coverage.t also optionally requires Pod::Coverage >= 0.18. Since you > run the other optional tests, perhaps you'd like to run this one as well? Indeed. Added > Removal of empty directories is unnecessary (line 38). Removed. > Since you're using the %license macro, I expect this to be purely a F21+ > package. Consider utilizing NO_PACKLIST, too. Ah, I didn't know about this trick. Very cool. Done (and yes, this package is for F21 and devel). Spec URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Struct/perl-CGI-Struct.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Struct/perl-CGI-Struct-1.21-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review