[Bug 1169284] Review Request: perl-CGI-Struct - Build structures from CGI data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1169284



--- Comment #1 from Petr Šabata <psabata@xxxxxxxxxx> ---
Oh c'mon, so many common things...

Missing BRs:  perl, Exporter, strict, warnings.

The minimum required version of Test::Pod is 1.22.
The minimum required version of Test::Pod::Coverage is 1.08.
Consider limiting the BRs to these versions.

00-pod-coverage.t also optionally requires Pod::Coverage >= 0.18.  Since you
run the other optional tests, perhaps you'd like to run this one as well?

Removal of empty directories is unnecessary (line 38).

Since you're using the %license macro, I expect this to be purely a F21+
package.  Consider utilizing NO_PACKLIST, too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]