https://bugzilla.redhat.com/show_bug.cgi?id=1115679 Piotr Popieluch <piotr1212@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review- --- Comment #1 from Piotr Popieluch <piotr1212@xxxxxxxxx> --- Some comments: - Please update to latest upstream release if possible. - Are following BuildRequires needed? If so could add a comment explaining why, there is nothing being built. If they are needed for tests put them in the %if 0%{?enable_tests} conditional. BuildRequires: nodejs-saucelabs BuildRequires: nodejs-q BuildRequires: nodejs-colors BuildRequires: nodejs-lodash BuildRequires: nodejs-sauce-tunnel BuildRequires: nodejs-grunt BuildRequires: nodejs-request - You can leave out following "Requires:" they should be handled automatically, see: https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/Packagers#Automatic_Requires_and_Provides If automatic requires don't work, please add an comment explaining. Requires: nodejs-saucelabs Requires: nodejs-q Requires: nodejs-colors Requires: nodejs-lodash Requires: nodejs-sauce-tunnel Requires: nodejs-grunt Requires: nodejs-request - Add the buildarch noarch as you did in nodejs-saucelabs - Could you explain why the %nodejs_fixdep are needed? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review