https://bugzilla.redhat.com/show_bug.cgi?id=1161834 Antonio Trande <anto.trande@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anto.trande@xxxxxxxxx --- Comment #5 from Antonio Trande <anto.trande@xxxxxxxxx> --- - Various basic macros are already defined on RPM, these lines are redundant %define name girl %define ver 0.5.1 %define rel 1 %define prefix %{_usr} %define docdir %{_defaultdocdir} BuildRoot: %{_tmppath}/%{name}-root mkdir -p %{buildroot}%{_bindir} %defattr (-,root,root) %clean rm -rf %{buildroot} - The %makeinstall macro should not be used. See http://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_macro_should_not_be_used For infos see these guidelines: http://fedoraproject.org/wiki/Packaging:Guidelines and http://fedoraproject.org/wiki/How_to_create_an_RPM_package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review