https://bugzilla.redhat.com/show_bug.cgi?id=1120771 Jaroslav Škarvada <jskarvad@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jskarvad@redhat.c | |om) | --- Comment #5 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- (In reply to Jan Synacek from comment #4) Thanks for the review. > [ ]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. > [ ]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses found: > "GPL (v2 or later) (with incorrect FSF address)", "Unknown or > generated". > 22 files have unknown license. Detailed output of licensecheck in > /home/jsynacek/work/reviews/uronode/1120771-uronode/licensecheck.txt > > > It looks like the legal question hasn't been sorted out yet. > I will sort it out, somehow :) > [ ]: Package must own all directories that it creates. > Note: Directories without known owners: /etc/ax25 > > > This directory is missing in %files. > Bug 1168929. > > > [ ]: Spec file is legible and written in American English. > > > Almost. In the description, s/colours/colors/. > Oxford Dictionary spelling. No problem to switch it to American. > [ ]: Package contains systemd file(s) if in need. > > > Yes. There is also a xinetd file, which could be easily substituted with a > systemd service/socket pair. It's not a problem, but IMHO a preferred > solution. > NP, I will add it. > [ ]: Useful -debuginfo package or justification otherwise. > > > Debuginfo is empty... > Thanks for catching, there were hidden strips :) > uronode.x86_64: E: incorrect-fsf-address /usr/share/doc/uronode/LICENSE > > > Please, notify upstream about this. > Upstream was already notified. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review