https://bugzilla.redhat.com/show_bug.cgi?id=1120771 Jan Synacek <jsynacek@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jskarvad@xxxxxxxxxx Flags| |needinfo?(jskarvad@redhat.c | |om) --- Comment #4 from Jan Synacek <jsynacek@xxxxxxxxxx> --- [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later) (with incorrect FSF address)", "Unknown or generated". 22 files have unknown license. Detailed output of licensecheck in /home/jsynacek/work/reviews/uronode/1120771-uronode/licensecheck.txt It looks like the legal question hasn't been sorted out yet. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /etc/ax25 This directory is missing in %files. [ ]: Spec file is legible and written in American English. Almost. In the description, s/colours/colors/. [ ]: Package contains systemd file(s) if in need. Yes. There is also a xinetd file, which could be easily substituted with a systemd service/socket pair. It's not a problem, but IMHO a preferred solution. [ ]: Useful -debuginfo package or justification otherwise. Debuginfo is empty... [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: ftp://ftp.n1uro.net/packet/uronode-2.1.tar.gz Not sure why, manual download works. No problem. Rpmlint ------- Checking: uronode-2.1-2.fc20.x86_64.rpm uronode-2.1-2.fc20.src.rpm uronode.x86_64: W: spelling-error %description -l en_US digipeating -> digitizing uronode.x86_64: W: spelling-error %description -l en_US flexnet -> flex net, flex-net, fleetness uronode.x86_64: W: spelling-error %description -l en_US colours -> colors, co lours, co-lours uronode.x86_64: E: non-readable /etc/ax25/uronode.users 0600L uronode.x86_64: E: non-readable /etc/ax25/uronode.perms 0600L Readable by root. No problem. uronode.x86_64: E: incorrect-fsf-address /usr/share/doc/uronode/LICENSE Please, notify upstream about this. uronode.x86_64: W: log-files-without-logrotate /var/log/uronode Given that the journal is the preferred logging solution, I don't see a problem here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review