https://bugzilla.redhat.com/show_bug.cgi?id=1138455 --- Comment #4 from František Dvořák <valtri@xxxxxxxxxx> --- (In reply to Mamoru TASAKA from comment #3) > * Latest version > - is 4.3.2, please update (diff seems not so long) > OK. I used the older branch, where the dependent package rOCCI-server has fewer dependencies. But it's true it should be used the newest version, and there can be disabled some backends on the rOCCI-server, if needed. :-) > * %license > - For license file, using %license is now recommended. > Done. > * Usually non-needed files > - Files only used for test suite need not be packaged (spec/). > We usually don't package this on autotools based packages, > and it is explained also on: > > https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/ > Ruby#Running_test_suites > Done. I see, there is obvious "don't include tests" message. :-) > - Gemfile, Rakefile are alike "Makefile" in autotools based > packages and we usually don't need this on runtime. OK, removed. Thanks for the review! New version: Spec URL: http://scientific.zcu.cz/fedora/rubygem-occi-core-4.3.2-1/rubygem-occi-core.spec SRPM URL: http://scientific.zcu.cz/fedora/rubygem-occi-core-4.3.2-1/rubygem-occi-core-4.3.2-1.fc22.src.rpm * Thu Nov 27 2014 František Dvořák <valtri@xxxxxxxxxx> - 4.3.2-1 - Update to 4.3.2 - Removed rails >= 4.1 compatibility patch - The license file marked by %%license macro - Removed tests and build files -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review