https://bugzilla.redhat.com/show_bug.cgi?id=1138455 --- Comment #3 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- Mostly okay, some suggestions or so * Latest version - is 4.3.2, please update (diff seems not so long) * %license - For license file, using %license is now recommended. * Usually non-needed files - Files only used for test suite need not be packaged (spec/). We usually don't package this on autotools based packages, and it is explained also on: https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites - Gemfile, Rakefile are alike "Makefile" in autotools based packages and we usually don't need this on runtime. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review