https://bugzilla.redhat.com/show_bug.cgi?id=905240 --- Comment #21 from Vít Ondruch <vondruch@xxxxxxxxxx> --- Ingvar, if you don't mind, we'll finish the review. If you like, you can become co-maintainer if that works for you. * Documentation should be marked by %doc macro - %{gem_instdir}/doc should be marked as documentation. * Is the lib/log4r/rdoc runtime dependency? - Shouldn't it be moved into documentation? - Shouldn't it be removed? Isn't it just used to generate documentation? * Wrong license - As Ingvar pointed out, the license is a bit tricky, but I'd say that the last license mentioned for 1.10.0 is LGPLv3 [1]. I believe that it was relicensed, although the conditions of the relicensing are not very clear :/ * License file - Have you asked upstream to include the LICENSE file? * Execute test suite using Minitest 5.x - Have you considered to execute the test suite using Minitest 5.x? (please note that some of the points might be already obsolete with 1.11.0 release) [1] https://github.com/colbygk/log4r/tree/40e2c2edd657a21b34f09dec7de238f348b6f428 -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review