Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: wqy-bitmap-fonts - a fine-tuned Chinese bitmap font https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230560 ------- Additional Comments From petersen@xxxxxxxxxx 2007-05-04 08:47 EST ------- I am very sorry for taking so long to followup. I have been too busy recently. (In reply to comment #40) > * Summary and %description could be localized Would be nice. You could add the Chinese description with: %description -l zh_CN for instance if you wish. (In reply to comment #41) > 1. We have been working on vector CJK fonts for two years, and we are expecting > our first release this year. Because we developed our vector fonts in a quite > general way, so, instead of generating a single font, you will find a families > of fonts. To keep things simple and easy to manage, a separate project folder > is highly desired Ok. I just wondering about the naming too: "wenquanyi/wqy-bitmapfont/" vs say "wqy-bitmapfont/" or "wenquanyi-bitmap/" or "wenquanyi/bitmap/", or even "wenquanyi/misc/" as Yuan Yijun suggested. I suppose "wqy/bitmap/" would make the connection with the package name clearer, but that is ok. > 6. for %ghost, I simply copied from fonts-japanese > http://cvs.fedora.redhat.com/viewcvs/devel/fonts-japanese/fonts-japanese.spec?rev=1.25&view=markup I think it is good since fonts.dir is generated at install time. (In reply to comment #42) > * The font has BDF source so why not use that as Source0, and use bdftopcf to > generate PCF on the fly. Why not? Do you have a comment, Qianqian Fang? > * Keep old changelogs > I like old changelogs, especially for projects like WenQuanYi. :D It is ok to put a *summary* of upstream changes in the rpm changelog but the detailed upstream changes should be in the upstream changelog file. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review