https://bugzilla.redhat.com/show_bug.cgi?id=1164811 --- Comment #3 from Kashyap Chamarthy <kchamart@xxxxxxxxxx> --- (In reply to Parag AN(पराग) from comment #2) > Review: > > + Package built successful in mock (f22 x86_64) > > - rpmlint on generated rpms gave output > python-gertty.noarch: W: spelling-error %description -l en_US workflow -> > work flow, work-flow, workforce > python-gertty.noarch: W: spelling-error %description -l en_US repos -> > ropes, reps, repose > python-gertty.noarch: W: spelling-error %description -l en_US repo -> rope, > rep, reps > python-gertty.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/python-gertty/LICENSE > python-gertty.noarch: W: no-manual-page-for-binary gertty > python-gertty.src: W: spelling-error %description -l en_US workflow -> work > flow, work-flow, workforce > python-gertty.src: W: spelling-error %description -l en_US repos -> ropes, > reps, repose > python-gertty.src: W: spelling-error %description -l en_US repo -> rope, > rep, reps > 2 packages and 0 specfiles checked; 0 errors, 8 warnings. > > + Source verified with upstream as (sha256sum) > srpm tarball: > 8d731c6bd20bdd4ac0f0040338773e1292dee0e54f1089b150d05f0e358acfc0 > upstream tarball: > 8d731c6bd20bdd4ac0f0040338773e1292dee0e54f1089b150d05f0e358acfc0 > > + License is "ASL 2.0 " and included in its own text file. > > > Suggestions: > 1) Fix rpmlint warning wrong-file-end-of-line-encoding Fixed by having this in %setup section: sed -i 's/\r$//' <file_to_strip> Result: $ rpmlint python-gertty.spec /home/kashyap/rpmbuild/RPMS/noarch/python-gertty-1.0.3-2.fc20.noarch.rpm python-gertty.noarch: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce python-gertty.noarch: W: spelling-error %description -l en_US repos -> ropes, reps, repose python-gertty.noarch: W: spelling-error %description -l en_US repo -> rope, rep, reps python-gertty.noarch: W: no-manual-page-for-binary gertty 1 packages and 1 specfiles checked; 0 errors, 4 warnings. > > 2) In spec at one line you have > %{python_sitelib}/%{pypi_name} > should be > %{python2_sitelib}/%{pypi_name} Fixed. > > 3) you can use > %{_prefix}/share/%{pypi_name}/examples/* > as > %{_datadir}/%{pypi_name}/examples/* Fixed. Thank you for the review. Updated SPEC and SRPM: SPEC: https://kashyapc.fedorapeople.org/spec-files/python-gertty.spec SRPM: https://kashyapc.fedorapeople.org/srpms/python-gertty-1.0.3-2.fc20.src.rpm * Wed Nov 19 2014 Kashyap Chamarthy <kashyapc@xxxxxxxxxxxxxxxxx> - 1.0.3-2 - Fix rpmlint warnings (wrong-file-end-of-line-encoding) - Fix and simplify RPM macros -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review