[Bug 1164811] Review Request: python-gertty - Gertty is a console-based interface to the Gerrit Code Review system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1164811

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ Package built successful in mock (f22 x86_64)

- rpmlint on generated rpms gave output
python-gertty.noarch: W: spelling-error %description -l en_US workflow -> work
flow, work-flow, workforce
python-gertty.noarch: W: spelling-error %description -l en_US repos -> ropes,
reps, repose
python-gertty.noarch: W: spelling-error %description -l en_US repo -> rope,
rep, reps
python-gertty.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/python-gertty/LICENSE
python-gertty.noarch: W: no-manual-page-for-binary gertty
python-gertty.src: W: spelling-error %description -l en_US workflow -> work
flow, work-flow, workforce
python-gertty.src: W: spelling-error %description -l en_US repos -> ropes,
reps, repose
python-gertty.src: W: spelling-error %description -l en_US repo -> rope, rep,
reps
2 packages and 0 specfiles checked; 0 errors, 8 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball: 8d731c6bd20bdd4ac0f0040338773e1292dee0e54f1089b150d05f0e358acfc0
upstream tarball:
8d731c6bd20bdd4ac0f0040338773e1292dee0e54f1089b150d05f0e358acfc0

+ License is "ASL 2.0 " and included in its own text file.


Suggestions:
1) Fix rpmlint warning wrong-file-end-of-line-encoding

2) In spec at one line you have
%{python_sitelib}/%{pypi_name}
should be
%{python2_sitelib}/%{pypi_name}

3) you can use
%{_prefix}/share/%{pypi_name}/examples/*
as
%{_datadir}/%{pypi_name}/examples/*

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]