[Bug 1086245] Review Request: nodejs-jsonstream -streaming JSON.parse and stringify for Node.js

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1086245



--- Comment #4 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> ---
For the record:

On Nov 16, 2014 3:57 AM, "Tom Hughes" <tom@xxxxxxxxxx> wrote:
>
> I'm working on a review (BZ#1086245) for nodejs-jsonstream.
>
> Now the interesting thing is that the module it is packaging is actually called JSONStream in the npm registry and there is in fact a separate jsonstream module.
>
> The general naming rules say that "You should generally use lowercase" but I guess this is a case where the node naming rules should take precedence, especially given that there is a conflict and we may need have both at some point?

Unfortunately the guidelines also forbid having two packages with names that
differ only by case:
http://fedoraproject.org/wiki/Packaging:Conflicts#Conflicting_Package_Names

Also, these days npm doesn't allow uppercase letters in package names, so stuff
like this can't happen anymore:
https://github.com/npm/npm/issues/3914

The uppercased version is older and more recently updated:

JSONStream:
"modified":"2014-08-04T19:15:52.140Z",
"created":"2011-09-23T11:01:36.806Z"

jsonstream: 
"modified":"2013-06-11T13:36:13.038Z",
"created":"2013-06-11T13:36:11.463Z"

Therefore, I believe JSONStream the capitalized deserves the name. I'm about to
send a mail to both upstreams and the npm registry admins to this effect (with
you and Anish on CC). Let's wait and see what they say.

If the capitalized version keeps the name, I would strongly recommend still
calling the RPM package "nodejs-JSONStream" with the capitals so users don't
mistake it for the lowercased version. I think this is a sufficient enough
"compelling reason to follow a different upstream convention" as required by
the guidelines.

-T.C.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]