[Bug 1086245] Review Request: nodejs-jsonstream -streaming JSON.parse and stringify for Node.js

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1086245



--- Comment #3 from Tom Hughes <tom@xxxxxxxxxx> ---
A few issues for you to look at:

* Upstream has now released 0.9.0

* The license tag should be "MIT or ASL 2.0"

* Summary is missing an initial capital letter

* No need to install test directory, and example should be in %doc not
installed

* Missing a %check to run the tests, though I see we are missing some of the
modules so that probably isn't possible to enable yet - they do all appear to
pass with it-is and event-stream installed locally

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]