https://bugzilla.redhat.com/show_bug.cgi?id=1161014 --- Comment #12 from Jens Petersen <petersen@xxxxxxxxxx> --- Thanks, Mukundan (In reply to Mukundan Ragavan from comment #11) > - Package contains BR: python2-devel or python3-devel > > ---> I think this is fine. > > There is Buildrequires: python, Is that what is triggering this? Perhaps. Let me change it to python2-devel to see if that will silence the warning. https://fedoraproject.org/wiki/Packaging:Python#BuildRequires > [x]: License file installed when any subpackage combination is installed. > > ---> About this - > > Can you use the %license macro for this since this is a new package anyway? Okay thanks and I will move the license file to libs too. > [?]: %build honors applicable compiler flags or justifies otherwise. > > ---> Please remove -O3 from the flags or add a note. I would prefer to > remove this. However, since llvm spec does not say why this was added (I am > sure there was a good reason), I am just confused. Thoughts? Okay let me comment it out for now: I wonder if it has caused any problems. I also mailed the committer asking if he can comment on it. > [x]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in llvm34-doc > , llvm34-libs , llvm34-static > > ---> Discussed in the previous review. No issues. Thanks: summarizing the current versioned reqs are: static -> devel -> base -> libs (as for llvm). > llvm34.src: W: patch-not-applied Patch20: clang-3.4-arm-hard-float.patch > llvm34.src: W: patch-not-applied Patch22: pr12586.patch Removing these. Spec: http://petersen.fedorapeople.org/reviews/llvm34/llvm34.spec SRPM: http://petersen.fedorapeople.org/reviews/llvm34/llvm34-3.4.2-4.fc20.src.rpm - BR python2-devel instead of python (#1161014) - drop -O3 config from llvm.spec for now (#1161014) - use license tag for license file and move license to libs (#1161014) - remove unused clang patches Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=8122183 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review