Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: camlimages - OCaml image processing library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235805 j.w.r.degoede@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |j.w.r.degoede@xxxxxx Flag| |fedora-review? ------- Additional Comments From j.w.r.degoede@xxxxxx 2007-05-03 08:52 EST ------- MUST: ===== 0 rpmlint output is: W: camlimages ocaml-naming-policy-not-applied /usr/lib/ocaml/camlimages/dllci_freetype.so W: camlimages-devel ocaml-naming-policy-not-applied /usr/lib/ocaml/camlimages/Makefile.config * Package and spec file named appropriately * Packaged according to packaging guidelines * License ok * spec file is legible and in Am. English. * Source matches upstream * Compiles and builds on devel i386 * BR: ok * No locales 0 No shared libraries, ldconfig not needed * Not relocatable * Package owns / or requires all dirs * No duplicate files & Permissions ok * %clean & macro usage OK * Contains code only * %doc does not affect runtime, and isn't large enough to warrent a sub package * -devel package as needed * no .desktop file needed MUST FIX ======== * rename to ocaml-images or ocaml-camlimages (will fix rpmlint warning, and the latter is consistent with PLD) * main package must require ocaml for /usr/lib/ocaml dir ownership * remove the unnecessary ldconfig %post(un) scripts, this are not normally libs and since they are not installed in a path searched by ldconfig, calling ldconfig is useless. * The .so files should be installed under /usr/lib/ocaml/stublibs Should Fix ========== * Please just list all the features one after the other seperated with ',', I don't think all rpm (gui) tools will preserve your formatting, so better to not format at all. * Stop the obfuscated double %setup usage, instead of the 2 lines you can just write: "%setup -q -n camlimages-2.2 -a 1" * Once the .so files are under %{_libdir}/ocaml/stublibs, the files for %devel can be written as just "%{_libdir}/ocaml/camlimages/" * also please always make all your %files entries like this: %files %defattr(....) %doc ... <other files and dirs> -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review