https://bugzilla.redhat.com/show_bug.cgi?id=1158999 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok sources: ok d1bdb44afd29974ac9362e9384296495 lxqt-session-0.8.0.tar.xz macros: ok scriptlets: ok, n/a 1. license: ok, but could be ammended to License: LGPLv2+ 2. SHOULD omit Obsoletes: razorqt-session <= 0.5.2 for now, until you and razorqt maintainers agree on a migration plan (if any). There are many other razorqt-related packages that need consideration wrt Obsoletes 3. SHOULD add Requires: xdg-utils since I see build flag, -DBUNDLE_XDG_UTILS=NO, I'd venture it may want it. Otherwise, it's small, simple, clean. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review