https://bugzilla.redhat.com/show_bug.cgi?id=1158632 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #7 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok license: ok sources: ok b48d6df01f23d56115448076ae875680 lxqt-common-0.8.0.tar.xz macros: ok scriptlets: ok 1. SHOULD omit: %{_datadir}/apps/kdm/sessions/lxqt.desktop that's the wrong path, and kdm only uses /usr/share/xsessions anyway. 2. SHOULD package fedora.theme separately (agreed to fix this post-review on irc) another relatively simple package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review