https://bugzilla.redhat.com/show_bug.cgi?id=1157201 Eduardo Echeverria <echevemaster@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |echevemaster@xxxxxxxxx --- Comment #3 from Eduardo Echeverria <echevemaster@xxxxxxxxx> --- Hi Parag, I'm serving as mentor of walter since the latest fudcon. (along with other guys) they are trying to package some flask libraries that yet not are in fedora. Walter, will be very appreciated that you could do some informal reviews to other packagers, or take some packages of the discussed list in fudcon. I'm able to sponsor to you, if one of these conditions are accomplished. So, we can pass to the comments. It is good habit, (in the case of python packages) see the setup.py, the requirements files, or the imports of the files for looking for the requires of the package. if you see the setup.py install_requires=["Flask", "six >= 1.7.3"], and in the flask-imgur.py you can see from six.moves import urllib As you can see, you need the requires, Flask and python-six - Take into account the William's comments. - Remove the flags of the %build section. it is only needed if the package contains arched contents - Clean manually the buildroot it is not necessary in newer versions of fedora (this applies only in epel5) - see %install section => rm -rf $RPM_BUILD_ROOT - BTW, remove the unneded comments # For noarch packages: sitelib And please, list the files one per one, this is not mandatory, but if in the future there are content that not accomplish with fedora guidelines, you can see of the quick way. => %{python_sitelib}/* Do you want package this for epel, if so, take into account that the macro %{_python2} does not exists there Use this workaround %{!?__python2: %global __python2 %{__python}} Also, will be good see the epel guidelines. Hoping your revisions. Thanks :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review