https://bugzilla.redhat.com/show_bug.cgi?id=1157201 William Moreno <williamjmorenor@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |williamjmorenor@xxxxxxxxx --- Comment #2 from William Moreno <williamjmorenor@xxxxxxxxx> --- Hello Walter: I am not a new packagers sponsonr but I can help in the review procces of your package with a informal review, please remember than you will need to look for a sponsor to aprove your request: I am only comments some points than require atention: [!]: Package consistently uses macros (instead of hard-coded directory names). We have defined this macros than you can use in the %%files sección %{python2_sitelib}/%{pypi_name} %{python2_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info If you are not going to Epel can remove firts lines of the .spec, this macros are allready defined in Fedora Here is a example of a .spec you can check: https://williamjmorenor.fedorapeople.org/rpmdev/python-slugify.spec Rpmlint ------- Checking: python-flask-imgur-0.1-1.fc20.noarch.rpm python-flask-imgur-0.1-1.fc20.src.rpm python-flask-imgur.noarch: E: description-line-too-long C This is simple flask extension allowing uploading images straight to Imgur image hosting service. python-flask-imgur.noarch: W: no-documentation python-flask-imgur.src: E: description-line-too-long C This is simple flask extension allowing uploading images straight to Imgur image hosting service. python-flask-imgur.src:31: W: macro-in-comment %{__python2} python-flask-imgur.src:45: W: macro-in-comment %{python_sitearch} 2 packages and 0 specfiles checked; 2 errors, 3 warnings. Error: Remember than spec file must fill in 80 characteres per line, Warning: You have this line in your %%files section # For arch-specific packages: sitearch #%{python_sitearch}/* If this is not needed remove it for the .spec Also upstream is not providing a License file in the tarball, you can patch it, and request upstream to add the License file in futures releases. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review