https://bugzilla.redhat.com/show_bug.cgi?id=1150512 --- Comment #3 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- (In reply to Jan Synacek from comment #2) Thanks for the review. > > Issues: > > ======= > > - Package contains BR: python2-devel or python3-devel > > I don't see any direct usage of python during the build. I don't think > any of these are required. > The python-devel packages is not mentioned in the spec, it seems it is installed as gnuradio-devel dependency: $ grep python ./gr-fcdproplus.spec %{python_sitearch}/* > > [ ]: Development (unversioned) .so files in -devel subpackage, if present. > > Note: Unversioned so-files in private %_libdir subdirectory (see > > attachment). Verify they are not in ld path. > > This is a python subdirectory with included swig bindings. I don't see > any problem with that. > My opinion is the same, the lib is not provided by the rpm package. > There is a clear mention in the spec file that the parallel build is broken. > No problem. > > > [ ]: Fully versioned dependency in subpackages if applicable. > > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gr- > > fcdproplus-devel , gr-fcdproplus-doc > > PROBLEM: probably doesn't matter for -doc, but -devel should have the > %{?_isa} part. > Thanks, fixed. > > Rpmlint (installed packages) > > ---------------------------- > > # rpmlint gr-fcdproplus-doc gr-fcdproplus gr-fcdproplus-devel > > gr-fcdproplus.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libgnuradio-fcdproplus.so.0.0.0 /lib64/libusb-1.0.so.0 > > gr-fcdproplus.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libgnuradio-fcdproplus.so.0.0.0 > > /lib64/libboost_filesystem.so.1.54.0 > > gr-fcdproplus.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libgnuradio-fcdproplus.so.0.0.0 /lib64/libm.so.6 > These should be fixed now. > > gr-fcdproplus-devel.x86_64: W: only-non-binary-in-usr-lib > This is rpmlint bug, other seems harmless. New version: Spec URL: https://fedorapeople.org/~jskarvad/gnuradio/gr-fcdproplus.spec SRPM URL: https://fedorapeople.org/~jskarvad/gnuradio/gr-fcdproplus-0-0.2.20140920git1edbe523.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review