[Bug 1150512] Review Request: gr-fcdproplus - GNURadio support for FUNcube Dongle Pro+

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1150512



--- Comment #2 from Jan Synacek <jsynacek@xxxxxxxxxx> ---
(In reply to Jan Synacek from comment #1)
> Issues:
> =======
> - Package contains BR: python2-devel or python3-devel

I don't see any direct usage of python during the build. I don't think
any of these are required.

> [ ]: Development (unversioned) .so files in -devel subpackage, if present.
>      Note: Unversioned so-files in private %_libdir subdirectory (see
>      attachment). Verify they are not in ld path.

This is a python subdirectory with included swig bindings. I don't see
any problem with that.

> [ ]: Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/lib/udev,
>      /usr/lib/udev/rules.d

These are owned by another package (systemd). No problem.

> [!]: Uses parallel make %{?_smp_mflags} macro.

There is a clear mention in the spec file that the parallel build is broken. No
problem.

> [ ]: Fully versioned dependency in subpackages if applicable.
>      Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gr-
>      fcdproplus-devel , gr-fcdproplus-doc

PROBLEM: probably doesn't matter for -doc, but -devel should have the %{?_isa}
part.

> Rpmlint
> -------
> Checking: gr-fcdproplus-0-0.1.20140920git1edbe523.fc20.x86_64.rpm
>           gr-fcdproplus-devel-0-0.1.20140920git1edbe523.fc20.x86_64.rpm
>           gr-fcdproplus-doc-0-0.1.20140920git1edbe523.fc20.noarch.rpm
>           gr-fcdproplus-0-0.1.20140920git1edbe523.fc20.src.rpm
> gr-fcdproplus-devel.x86_64: W: only-non-binary-in-usr-lib
> gr-fcdproplus-devel.x86_64: W: no-documentation
> gr-fcdproplus.src: W: invalid-url Source0:
> gr-fcdproplus-0-20140920git1edbe523.tar.bz2
> 4 packages and 0 specfiles checked; 0 errors, 3 warnings.
>
> Rpmlint (installed packages)
> ----------------------------
> # rpmlint gr-fcdproplus-doc gr-fcdproplus gr-fcdproplus-devel
> gr-fcdproplus.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libgnuradio-fcdproplus.so.0.0.0 /lib64/libusb-1.0.so.0
> gr-fcdproplus.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libgnuradio-fcdproplus.so.0.0.0
> /lib64/libboost_filesystem.so.1.54.0
> gr-fcdproplus.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libgnuradio-fcdproplus.so.0.0.0 /lib64/libm.so.6
> gr-fcdproplus-devel.x86_64: W: only-non-binary-in-usr-lib
> gr-fcdproplus-devel.x86_64: W: no-documentation
> 3 packages and 0 specfiles checked; 0 errors, 5 warnings.
> # echo 'rpmlint-done:'

I don't see any problems with these.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]