https://bugzilla.redhat.com/show_bug.cgi?id=1039323 nicolas.vieville@xxxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.vieville@univ-valen | |ciennes.fr --- Comment #6 from nicolas.vieville@xxxxxxxxxxxxxxxxxxxx --- Hello, As a candidate packager for Fedora, and if you still want to produce this package, I could make an unofficial review for your proposed package. I agree with all the point Mukudan gave you. As the shell script of this package is made for bash (specific use of bash arrays), it would probably better to explicitly indicate that it is required in the requires section of the spec file, even if bash and curl are "low-level" needed packages for the system. As the upstream web site points to github you should define global variables at the beginning of your spec file: %global commit 0fe94cb2fb10ef556e82dcce22260717c579f87a %global shortcommit %(c=%{commit}; echo ${c:0:7}) and then use them as this: Source0: https://github.com/subrosa2/weatherman/archive/%{commit}/weatherman-%{commit}.tar.gz or like this: %setup -qn %{name}-%{commit} in order to pass rpmlint tests. You should also use the directories predefined macros like this: %install install -D -m 0755 weatherman %{buildroot}%{_bindir}/weatherman install -D -m 0644 weatherman.1.gz %{buildroot}%{_mandir}/man1/weatherman.1.gz %files %{_bindir}/weatherman %doc CHANGES LICENSE %{_mandir}/man1/%{name}.1* Maybe it would be also useful to had an empty %build section to avoid rpmlint warning. If needed, I could provide you a modified spec file as an example. Let me know if you want me to make an unofficial review of your package, once you modified your spec file. Cordially, -- NVieville -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review