https://bugzilla.redhat.com/show_bug.cgi?id=1039323 Mukundan Ragavan <nonamedotc@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nonamedotc@xxxxxxxxx --- Comment #5 from Mukundan Ragavan <nonamedotc@xxxxxxxxx> --- Hi pphan12, I am also a new packager and here are some quick comments on the package. If something I mention here is wrong, I am sure someone will correct it. * source0: url is pasted twice. * License: BSD - The word 'license' need not be mentioned. It will cause rpmlint to throw errors. * %description - This section should have lines less than 80 characters. You can take a look at the common rpmlint errors wiki page. * Requires: curl - It is my belief that curl need not be added as requires. As far as I know it is not possible to remove curl from the system. * %post and % preun scriptlets - the source file does not seem provide any info manual. So, I am not sure these scriptlets are needed. * changelog - please check the format with other packages in the repository. Small changes are needed. Hope I have not made any mistakes here .. :) Good luck. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review