[Bug 235471] Review Request: perl-PDF-API2 - Perl module for creation and modification of PDF files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-PDF-API2 - Perl module for creation and modification of PDF files
Alias: perl-PDF-API2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235471





------- Additional Comments From cweyl@xxxxxxxxxxxxxxx  2007-04-29 16:55 EST -------
Ok, so :)  Sorry for the delay, but I wanted to both think this one through (and
had some sort of obsessive desire to get all of Catalyst-Devel's prereqs posted
for review<grin>)

So, fonts.  The key bits that control where fonts are looked for appears to be
at the beginning of lib/PDF/API2.pm:

"
    @FontDirs = ( (map { "$_/PDF/API2/fonts" } @INC),
        qw[ /usr/share/fonts /usr/local/share/fonts c:/windows/fonts
c:/winnt/fonts ] );
"

They do appear to be integral to the function and operation of the package.

I've taken a peek at a number of other font packages, the canonical place for
fonts seems to be /usr/share/fonts...  The bitstream-vera-fonts package has
%post and %postun scriptlets that seem to help with enabling other apps to use
these fonts.

So, my suggestion here would be to:
1. make a little patch to change @FontDirs defaults to sensible paths
2. move the fonts from their location in @INC to %{_sharedir}/fonts/%{name}
3. break the fonts out into a subpackage, requiring that subpackage by the main
package (but not vice-versa)
4. determine what %post/%postun scriptlets are needed to get these fonts
recognized and usable by the system
5. (really post-approval/import/build) include the sub-package in the right spot
in the comps.xml files such that people will see it with other fonts packages

That should break these fonts out in a sensible fashion that makes them
available to the rest of the system without impacting the functioning of this
module.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]