Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: widelands - realtime-strategy game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238270 bjohnson@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bjohnson@xxxxxxxxxxxx ------- Additional Comments From bjohnson@xxxxxxxxxxxx 2007-04-29 16:35 EST ------- I see several problems right away... 1. You might want to get some feedback on the version numbering. Upstream is pretty messed up. You way of handling it seems reasonable, but I've never seen it done that way. 2. During build: "WARNING: Could not find pngwrite. PNG compatification disabled." 3. Compile completely ignores CXXFLAGS, this is a blocker. 4. Does not update desktop database: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-de6770dd9867fcd085a73a4700f6bcd0d10294ef 5. During build: "Checking for EF_newFrame() in C library efence... no" Wants to be linked to ElectricFence?? 6. Several messages like this: msgmerge: error while opening "widelands_en_EN.po" for reading: No such file or directory msgfmt: error while opening "widelands_en_EN.po" for reading: No such file or directory are these actual problems? 7. Is this important: INFORMATION: Astyle produces malformed indentation (see for example [https://sourceforge.net/tracker/index.php?func=detail&aid=1642489&group_id=2319&atid=102319]) and is disabled whilst waiting for repair. If you really want to use it, execute "cd /usr/bin && ln -s astyle buggy-astyle" and try again. 8. Provides a lot of perl junk but doesn't require perl: Provides: perl(Client) perl(ProtocolPacket) perl(ProtocolPacket_ChatMessage) perl(ProtocolPacket_Connect) perl(ProtocolPacket_GetRoomInfo) perl(ProtocolPacket_GetUserInfo) perl(ProtocolPacket_Hello) perl(ProtocolPacket_Ping) perl(ProtocolPacket_UserEntered) perl(Server) This seems to be because of /usr/share/widelands/game_server. Possibly this might be better split off. But it certainly doesn't belong in the -data package. 9. Locale handling is incorrect: http://fedoraproject.org/wiki/Packaging/Guidelines#head-8c605ebf8330f6d505f384e671986fa99a8f72ee 10. Desktop database is not updated: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?#head-de6770dd9867fcd085a73a4700f6bcd0d10294ef -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review