https://bugzilla.redhat.com/show_bug.cgi?id=1099166 --- Comment #18 from Martín Buenahora <martinbuenahora@xxxxxxxxxxxxxxx> --- (In reply to Raphael Groner from comment #17) > This is no formal review. But I have some general comments to your spec file. > > > Name: screenFetch > Try to keep a consistent name and don't mix upper/lower-case: screenfetch > > > Version: 20140914git > Do you plan to release always from git with date as version? Maybe we should > think about a better versioning scheme to be able to switch to main > releases. At least put 0. before: 0.20140914git > > > %description > > screenFetch is a "Bash Screenshot Information Tool". > You can remove that line from %description, because it's / should be the > Summary. > > > %files > > … > > %{_mandir}/man1/screenfetch.1.gz > That manpage should be with %doc in front: > %doc %{_mandir}/man1/screenfetch.1.gz > > > > %changelog > > * Tue Sep 9 2014 Martín Buenahora <martin@localhost.localdomain> - 20140914git-1 > Please provide an official and working e-mail address. You can use your one > from FAS (login: zironid). Hello Raphael. I've changed the Summary, the manpages location and the e-mail (I'm using an Emacs that automatically adds entries to the changelog, and uses that as the default e-mail), and changed the F from the name. I have a doubt about the version. The upstream have releases, as you have seen, but they aren't really defined (I remember one commit that said something like "Is been a while since a new release"), so I don't know if I should come back to the releases, or if I should stay with the git version (I would use "<date>git<short commit>" rather than "<date>git"). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review