https://bugzilla.redhat.com/show_bug.cgi?id=979124 --- Comment #57 from Jake Petroules <jake.petroules@xxxxxxxxxxxxx> --- Gave this a brief look over, here's some issues I've found: - BuildRequires should probably have nodejs and typescript dependencies as there are autotests for these modules - In several places you've written qt, this should probably be Qt - Same with windows => Windows - nodejs/NodeJS => Node.js - linux => Linux - Remove darwin-tools.js from the list of removed files because that file is no longer in that directory (and no you cannot remove it from imports) - "# Remove the WiX-Module since it is only useful for Windows" -- not necessarily, some people have reported using WiX with Wine/Mono to build MSIs on Linux just as they do NSIS installers, and I would not consider this to be a terribly unusual use case nor do I want to artificially restrict people either (see: https://build.opensuse.org/package/view_file/GNOME:Apps:Evince:Windows:STABLE/mingw32-wix/mingw32-wix.spec?expand=1 & https://build.opensuse.org/package/show?package=wixwine&project=home%3Ahiberis%3Awix) - You can keep the IB module removed, unlike WiX I know of virtually no one who cross compiles for OS X (or iOS from anything other than OS X) let alone HAS a Linux port of ibtool... if that ever changes we can re-evaluate :) - ifarch x86_64 when setting the plugins path seems dangerous... what about ppc64, arm64, etc? Just set it unconditionally, no harm done there -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review