[Bug 1086790] Review Request: gnudos - A GNU library to help new users of the GNU system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1086790



--- Comment #23 from Mohammed Isam <mohammed_isam1984@xxxxxxxxx> ---
(In reply to Petr Šabata from comment #22)
> The tarball has changed without changing the version again.  This is bad
> practice.  The `Release' tag indicates only changes in Fedora packaging --
> if you, as upstream change the code itself, you should also bump the version
> (as in the `Version' tag).  This was already pointed out by Michael in
> comment #4.
> 
Silly mistake, the version ought to be 1.7. Sorry for that. Fixed

> Nope.  This was done by the `install' command (currently lines 51-54).  It'd
> be more clear if you used the -m option instead of the %attr macro.  See
> install(1) for details.
> 
Fixed.

> The package is in a passable state but I'll let you do another respin just
> for practice.
Updated. Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]