[Bug 1086790] Review Request: gnudos - A GNU library to help new users of the GNU system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1086790



--- Comment #22 from Petr Šabata <psabata@xxxxxxxxxx> ---
The tarball has changed without changing the version again.  This is bad
practice.  The `Release' tag indicates only changes in Fedora packaging -- if
you, as upstream change the code itself, you should also bump the version (as
in the `Version' tag).  This was already pointed out by Michael in comment #4.

Your upstream changelog refers to Fedora package releases but what if other
distributions want to package your software?  If you feel this is just a minor
update, release something like 1.6.1 and then reset the `Release' number in
Fedora, so it becomes 1.6.1-1...  that's just an example, the versioning scheme
doesn't matter.  Just realise those are two different things -- the upstream
version and the Fedora package version.

(In reply to Mohammed Isam from comment #20)
> > Update the Texinfo index before the package gets uninstalled, i.e. in a
> > %preun section, not %postun.
> 
> Fixed. That solved it, it was bugging me because rpm was always complaining
> on removing the package.

Ack, handled well now.

> > Also, your Texinfo files have strange permissions (755).  Remove the
> > executable bits.
> 
> Fixed. These bit permissions are set by install-info. I changed the files
> permission in the %files section.

Nope.  This was done by the `install' command (currently lines 51-54).  It'd be
more clear if you used the -m option instead of the %attr macro.  See
install(1) for details.


The package is in a passable state but I'll let you do another respin just for
practice.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]